Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: components/signin/core/browser/account_tracker_service.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/core/common/policy_test_utils.cc ('k') | components/update_client/component_patcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/account_tracker_service.cc
diff --git a/components/signin/core/browser/account_tracker_service.cc b/components/signin/core/browser/account_tracker_service.cc
index 12965902a881cfc659eb94afb6895bbca2b857e4..b1dc370db2b727dddebcc37796f50de2687905b8 100644
--- a/components/signin/core/browser/account_tracker_service.cc
+++ b/components/signin/core/browser/account_tracker_service.cc
@@ -348,7 +348,7 @@ void AccountTrackerService::LoadFromPrefs() {
if (dict->GetList(kAccountServiceFlagsPath, &service_flags_list)) {
contains_deprecated_service_flags = true;
std::string flag_string;
- for (base::Value* flag : *service_flags_list) {
+ for (const auto& flag : *service_flags_list) {
if (flag->GetAsString(&flag_string) &&
flag_string == kChildAccountServiceFlag) {
is_child_account = true;
« no previous file with comments | « components/policy/core/common/policy_test_utils.cc ('k') | components/update_client/component_patcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698