components/ntp_snippets/ntp_snippet.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippet.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippet.cc

diff --git a/components/ntp_snippets/ntp_snippet.cc b/components/ntp_snippets/ntp_snippet.cc

index d74274b658f54b1a8b4509de3aaaf33d7e3f59df..037fe51b2c11abc029ec88884aa1c92b4d133224 100644

--- a/components/ntp_snippets/ntp_snippet.cc

+++ b/components/ntp_snippets/ntp_snippet.cc

@@ -71,7 +71,7 @@ std::unique_ptr<NTPSnippet> NTPSnippet::CreateFromDictionary(

return nullptr;

}

- for (base::Value* value : *corpus_infos_list) {

+ for (const auto& value : *corpus_infos_list) {

const base::DictionaryValue* dict_value = nullptr;

if (!value->GetAsDictionary(&dict_value)) {

DLOG(WARNING) << "Invalid source info for article " << id;

@@ -149,7 +149,7 @@ std::unique_ptr<NTPSnippet> NTPSnippet::CreateFromDictionary(

// static

bool NTPSnippet::AddFromListValue(const base::ListValue& list,

PtrVector* snippets) {

- for (const base::Value* const value : list) {

+ for (const auto& value : list) {

const base::DictionaryValue* dict = nullptr;

if (!value->GetAsDictionary(&dict))

return false;