components/arc/net/arc_net_host_impl.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/net/arc_net_host_impl.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/system/statistics_provider.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/arc/net/arc_net_host_impl.cc

diff --git a/components/arc/net/arc_net_host_impl.cc b/components/arc/net/arc_net_host_impl.cc

index e2472b696af1075808bcf3e7a7372e7e09eeec9b..985ef6a8733d8dccd6d9b9072858448526a009f3 100644

--- a/components/arc/net/arc_net_host_impl.cc

+++ b/components/arc/net/arc_net_host_impl.cc

@@ -369,7 +369,7 @@ void ArcNetHostImpl::GetNetworks(mojom::GetNetworksRequestType type,

// property.

mojo::Array<mojom::WifiConfigurationPtr> networks =

mojo::Array<mojom::WifiConfigurationPtr>::New(0);

- for (base::Value* value : *network_properties_list) {

+ for (const auto& value : *network_properties_list) {

mojom::WifiConfigurationPtr wc = mojom::WifiConfiguration::New();

base::DictionaryValue* network_dict = nullptr;