chrome/common/extensions/manifest_handlers/linked_app_icons.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/linked_app_icons.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc ('k') | chrome/service/cloud_print/printer_job_queue_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/linked_app_icons.cc

diff --git a/chrome/common/extensions/manifest_handlers/linked_app_icons.cc b/chrome/common/extensions/manifest_handlers/linked_app_icons.cc

index 5f4945ebc9244b4743c1028049e04925154d797e..b1f089cf8dce37d8ef207778645f2ab1ffa997a6 100644

--- a/chrome/common/extensions/manifest_handlers/linked_app_icons.cc

+++ b/chrome/common/extensions/manifest_handlers/linked_app_icons.cc

@@ -68,7 +68,7 @@ bool LinkedAppIconsHandler::Parse(Extension* extension, base::string16* error) {

return false;

}

- for (const base::Value* icon_value : *icons_list) {

+ for (const auto& icon_value : *icons_list) {

const base::DictionaryValue* icon_dict = nullptr;

if (!icon_value->GetAsDictionary(&icon_dict)) {

*error = base::UTF8ToUTF16(