Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1850)

Unified Diff: chrome/browser/interests/interests_fetcher.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/interests/interests_fetcher.cc
diff --git a/chrome/browser/interests/interests_fetcher.cc b/chrome/browser/interests/interests_fetcher.cc
index 49ba04da0682daa3d12d61e2232c6dc750192d95..0b755d11b07842fb46ba8e567b25556e81ddd509 100644
--- a/chrome/browser/interests/interests_fetcher.cc
+++ b/chrome/browser/interests/interests_fetcher.cc
@@ -182,7 +182,7 @@ InterestsFetcher::ExtractInterests(const std::string& response) {
}
std::unique_ptr<std::vector<Interest>> res(new std::vector<Interest>());
- for (const base::Value* entry : *interests_list) {
+ for (const auto& entry : *interests_list) {
const base::DictionaryValue* interest_dict = nullptr;
if (!entry->GetAsDictionary(&interest_dict)) {
DLOG(WARNING) << "Failed to parse interest dictionary.";
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698