chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/gcd_private/privet_v3_session.cc ('k') | chrome/browser/extensions/extension_override_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index ef6ce09458de7f80e7b63c5fc7116b9604f99396..fa961689ac2d281dec2468aef89b96e105e6fe3a 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -490,15 +490,13 @@ class IdentityGetAccountsFunctionTest : public ExtensionBrowserTest {

if (!results) {

msg << "NULL";

} else {

- for (base::ListValue::const_iterator it = results->begin();

- it != results->end();

- ++it) {

+ for (const auto& result : *results) {

std::unique_ptr<api::identity::AccountInfo> info =

- api::identity::AccountInfo::FromValue(**it);

+ api::identity::AccountInfo::FromValue(*result);

if (info.get())

msg << info->id << " ";

else

- msg << *it << "<-" << (*it)->GetType() << " ";

+ msg << *result << "<-" << result->GetType() << " ";

}