chrome/browser/chromeos/platform_keys/key_permissions.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/platform_keys/key_permissions.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/webui_login_view.cc ('k') | chrome/browser/devtools/devtools_embedder_message_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/platform_keys/key_permissions.cc

diff --git a/chrome/browser/chromeos/platform_keys/key_permissions.cc b/chrome/browser/chromeos/platform_keys/key_permissions.cc

index 4f208e5921bfa39903ecdf80578f0535bb150eb6..fb260419341ded35e59af68f7289d441661f6f1d 100644

--- a/chrome/browser/chromeos/platform_keys/key_permissions.cc

+++ b/chrome/browser/chromeos/platform_keys/key_permissions.cc

@@ -246,7 +246,7 @@ void KeyPermissions::PermissionsForExtension::KeyEntriesFromState(

LOG(ERROR) << "Found a state store of wrong type.";

return;

}

- for (const base::Value* entry : *entries) {

+ for (const auto& entry : *entries) {

if (!entry) {

LOG(ERROR) << "Found invalid NULL entry in PlatformKeys state store.";

continue;