Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

services/catalog/entry.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/catalog/entry.h"
 
 #include "base/values.h"
 #include "services/catalog/store.h"
 #include "services/shell/public/cpp/names.h"
 
 namespace catalog {
 namespace {
 
 bool ReadStringSet(const base::ListValue& list_value,
                    std::set<std::string>* string_set) {
   DCHECK(string_set);
-  for (auto i = list_value.begin(); i != list_value.end(); ++i) {
+  for (const auto& value_value : list_value) {
     std::string value;
-    const base::Value* value_value = *i;
     if (!value_value->GetAsString(&value)) {
       LOG(ERROR) << "Entry::Deserialize: list member must be a string";
       return false;
     }
     string_set->insert(value);
   }
   return true;
 }
 
 bool ReadStringSetFromValue(const base::Value& value,
@@ skipping 259 matching lines @@
 catalog::mojom::EntryPtr
     TypeConverter<catalog::mojom::EntryPtr, catalog::Entry>::Convert(
         const catalog::Entry& input) {
   catalog::mojom::EntryPtr result(catalog::mojom::Entry::New());
   result->name = input.name();
   result->display_name = input.display_name();
   return result;
 }
 
 }  // namespace mojo