Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

chromecast/crash/linux/synchronized_minidump_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/crash/linux/synchronized_minidump_manager.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <stddef.h>
@@ skipping 274 matching lines @@
   metadata_ = std::move(metadata);
   return 0;
 }
 
 int SynchronizedMinidumpManager::WriteFiles(const base::ListValue* dumps,
                                             const base::Value* metadata) {
   DCHECK(dumps);
   DCHECK(metadata);
   std::string lockfile;
 
-  for (const base::Value* elem : *dumps) {
+  for (const auto& elem : *dumps) {
     std::unique_ptr<std::string> dump_info = SerializeToJson(*elem);
     RCHECK(dump_info, -1);
     lockfile += *dump_info;
     lockfile += "\n";  // Add line seperatators
   }
 
   if (WriteFile(base::FilePath(lockfile_path_),
                 lockfile.c_str(),
                 lockfile.size()) < 0) {
     return -1;
@@ skipping 51 matching lines @@
     lockfile_fd_ = -1;
   }
 
   dumps_.reset();
   metadata_.reset();
 }
 
 ScopedVector<DumpInfo> SynchronizedMinidumpManager::GetDumps() {
   ScopedVector<DumpInfo> dumps;
 
-  for (const base::Value* elem : *dumps_) {
-    dumps.push_back(new DumpInfo(elem));
+  for (const auto& elem : *dumps_) {
+    dumps.push_back(new DumpInfo(elem.get()));
   }
 
   return dumps;
 }
 
 int SynchronizedMinidumpManager::SetCurrentDumps(
     const ScopedVector<DumpInfo>& dumps) {
   dumps_->Clear();
 
   for (DumpInfo* dump : dumps)
@@ skipping 51 matching lines @@
 
     const std::string file_path = dump_path_.Append(reader.name()).value();
     if (file_path != lockfile_path_ && file_path != metadata_path_)
       return true;
   }
 
   return false;
 }
 
 }  // namespace chromecast