Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2000783002: Exit before reaching some Nonfatal errors (Closed)

Created:
4 years, 7 months ago by scroggo_chromium
Modified:
4 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@opaque
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Exit before reaching some Nonfatal errors BRDCodecSrc will quit early if the width or height after sampling is <= 10. Move that check earlier, to before we even create the BRDCodecSrc. Although this dropped my srcs (when running over resources/) from 3544 to 3030 (over 500 less), it did not have much of an impact on time. BUG=skia:5307 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000783002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M dm/DM.cpp View 4 chunks +22 lines, -15 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 1 (1 generated)
scroggo_chromium
4 years, 7 months ago (2016-05-20 18:39:30 UTC) #1
Description was changed from

==========
Exit before reaching some Nonfatal errors

BRDCodecSrc will quit early if the width or height after sampling
is <= 10. Move that check earlier, to before we even create the
BRDCodecSrc.

Although this dropped my srcs (when running over resources/) from
3544 to 3030 (over 500 less), it did not have much of an impact on
time.

BUG=skia:5307
==========

to

==========
Exit before reaching some Nonfatal errors

BRDCodecSrc will quit early if the width or height after sampling
is <= 10. Move that check earlier, to before we even create the
BRDCodecSrc.

Although this dropped my srcs (when running over resources/) from
3544 to 3030 (over 500 less), it did not have much of an impact on
time.

BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000783002
==========

Powered by Google App Engine
This is Rietveld 408576698