third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2000763003: Check subtree paint invalidation when overflow clip status changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2000763003: Check subtree paint invalidation when overflow clip status changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 53f927924bde1305ce1797ab6daa42d348176ceb..2c78f6a39117575870ffa7360b009fc29cd3f7bb 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -396,7 +396,6 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState&

LayoutRect previousPaintInvalidationRect = this->previousPaintInvalidationRect();

LayoutPoint previousPosition = previousPositionFromPaintInvalidationBacking();

PaintInvalidationReason reason = invalidatePaintIfNeeded(newPaintInvalidationState);

- clearPaintInvalidationFlags(newPaintInvalidationState);

if (previousPosition != previousPositionFromPaintInvalidationBacking())

newPaintInvalidationState.setForceSubtreeInvalidationCheckingWithinContainer();

@@ -416,6 +415,7 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState&

newPaintInvalidationState.setForceSubtreeInvalidationRectUpdateWithinContainer();

newPaintInvalidationState.updateForChildren(reason);

+ clearPaintInvalidationFlags(newPaintInvalidationState);

chrishtr 2016/05/23 20:10:32 What does this have to do with the fix here?

Xianzhu 2016/05/23 21:35:49 Now we check m_currentObject.mayNeedPaintInvalidat

invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);

}