Check subtree paint invalidation when overflow clip status changes

third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

 /*
  * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
  * Copyright (C) 2006 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 125 matching lines @@
 
 void LayoutSVGInline::removeChild(LayoutObject* child)
 {
     SVGResourcesCache::clientWillBeRemovedFromTree(child);
 
     if (LayoutSVGText* textLayoutObject = LayoutSVGText::locateLayoutSVGTextAncestor(this))
         textLayoutObject->subtreeChildWillBeRemoved();
     LayoutInline::removeChild(child);
 }
 
-void LayoutSVGInline::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)

[chrishtr, 2016/05/23 20:10:32]

This looks different than LayoutBoxModelObject::invalidateTreeIfNeeded, which it
inherits from.

[Xianzhu, 2016/05/23 21:35:49]

I noticed this but thought LayoutBoxModelObject::invalidateTreeIfNeeded() is
also applicable to LayoutSVGInline. However, I defer this change for more
verifications. In the new patch this method calls
LayoutObject::invalidateTreeIfNeeded().

-{
-    ASSERT(!needsLayout());
-
-    if (!shouldCheckForPaintInvalidation(paintInvalidationState))
-        return;
-
-    PaintInvalidationState newPaintInvalidationState(paintInvalidationState, *this);
-    PaintInvalidationReason reason = invalidatePaintIfNeeded(newPaintInvalidationState);
-    clearPaintInvalidationFlags(newPaintInvalidationState);
-
-    newPaintInvalidationState.updateForChildren(reason);
-    invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);
-}
-
 } // namespace blink