Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2000743002: [battor agent] Add 'read more bytes' logic in the BattOr connection (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
aschulman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[battor agent] Add 'read more bytes' logic in the BattOr connection Right now, when one read doesn't result in a complete message, the read fails and retries up to RETRY_COUNT (3) times. However, the BattOr connection SHOULD read more data from the serial connection until: 1) A complete message is read 2) Bytes are read that are irrecoverably erroneous in some way or 3) More bytes are read than the maximum message length This CL makes this the case. BUG=613562 Committed: https://crrev.com/f7b11a03318b4e244bb743bb506afc702d7e8f7c Cr-Commit-Position: refs/heads/master@{#395110}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -38 lines) Patch
M tools/battor_agent/battor_connection_impl.h View 1 chunk +12 lines, -3 lines 0 comments Download
M tools/battor_agent/battor_connection_impl.cc View 6 chunks +58 lines, -31 lines 0 comments Download
M tools/battor_agent/battor_connection_impl_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-05-20 15:19:31 UTC) #4
aschulman
lgtm
4 years, 7 months ago (2016-05-20 16:11:29 UTC) #5
aschulman
lgtm
4 years, 7 months ago (2016-05-20 16:11:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000743002/20001
4 years, 7 months ago (2016-05-20 17:10:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-20 17:53:10 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 17:55:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7b11a03318b4e244bb743bb506afc702d7e8f7c
Cr-Commit-Position: refs/heads/master@{#395110}

Powered by Google App Engine
This is Rietveld 408576698