Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2000733002: [turbofan] Unify escape analysis offset calculation. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify escape analysis offset calculation. This unifies the calculation of virtual offsets within the escape analysis pass to go through common helpers. It also switches to safer accessors for getting FieldAccess and ElementAccess parameters. R=jarin@chromium.org Committed: https://crrev.com/09365ad8112317bfcbd7b2094c5cd065f11f4a9e Cr-Commit-Position: refs/heads/master@{#36423}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M src/compiler/escape-analysis.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/escape-analysis.cc View 1 7 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-20 14:27:02 UTC) #1
Jarin
lgtm
4 years, 7 months ago (2016-05-20 14:35:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000733002/20001
4 years, 7 months ago (2016-05-20 16:00:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 17:51:06 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 17:53:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09365ad8112317bfcbd7b2094c5cd065f11f4a9e
Cr-Commit-Position: refs/heads/master@{#36423}

Powered by Google App Engine
This is Rietveld 408576698