Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: include/core/SkImageInfo.h

Issue 2000713003: Add SkColorSpace to SkImageInfo (Closed) Base URL: https://skia.googlesource.com/skia.git@public
Patch Set: Ref counting fixes and other fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/core/SkImageInfo.h
diff --git a/include/core/SkImageInfo.h b/include/core/SkImageInfo.h
index 4b308c05d88ca736d69451f3b970c1bd71b30b12..fe98d306dda5c02ebeed6e1304891095fe7575cc 100644
--- a/include/core/SkImageInfo.h
+++ b/include/core/SkImageInfo.h
@@ -8,6 +8,7 @@
#ifndef SkImageInfo_DEFINED
#define SkImageInfo_DEFINED
+#include "SkColorSpace.h"
#include "SkMath.h"
#include "SkRect.h"
#include "SkSize.h"
@@ -187,19 +188,23 @@ public:
, fColorType(kUnknown_SkColorType)
, fAlphaType(kUnknown_SkAlphaType)
, fProfileType(kLinear_SkColorProfileType)
+ , fColorSpace(nullptr)
{}
static SkImageInfo Make(int width, int height, SkColorType ct, SkAlphaType at,
SkColorProfileType pt = kLinear_SkColorProfileType) {
- return SkImageInfo(width, height, ct, at, pt);
+ return SkImageInfo(width, height, ct, at, pt, nullptr);
}
+ static SkImageInfo Make(int width, int height, SkColorType ct, SkAlphaType at,
+ sk_sp<SkColorSpace> cs);
+
/**
* Sets colortype to the native ARGB32 type.
*/
static SkImageInfo MakeN32(int width, int height, SkAlphaType at,
SkColorProfileType pt = kLinear_SkColorProfileType) {
- return SkImageInfo(width, height, kN32_SkColorType, at, pt);
+ return SkImageInfo(width, height, kN32_SkColorType, at, pt, nullptr);
}
/**
@@ -207,7 +212,7 @@ public:
*/
static SkImageInfo MakeN32Premul(int width, int height,
SkColorProfileType pt = kLinear_SkColorProfileType) {
- return SkImageInfo(width, height, kN32_SkColorType, kPremul_SkAlphaType, pt);
+ return SkImageInfo(width, height, kN32_SkColorType, kPremul_SkAlphaType, pt, nullptr);
}
/**
@@ -220,12 +225,12 @@ public:
static SkImageInfo MakeA8(int width, int height) {
return SkImageInfo(width, height, kAlpha_8_SkColorType, kPremul_SkAlphaType,
- kLinear_SkColorProfileType);
+ kLinear_SkColorProfileType, nullptr);
}
static SkImageInfo MakeUnknown(int width, int height) {
return SkImageInfo(width, height, kUnknown_SkColorType, kUnknown_SkAlphaType,
- kLinear_SkColorProfileType);
+ kLinear_SkColorProfileType, nullptr);
}
static SkImageInfo MakeUnknown() {
@@ -236,6 +241,9 @@ public:
int height() const { return fHeight; }
SkColorType colorType() const { return fColorType; }
SkAlphaType alphaType() const { return fAlphaType; }
+ SkColorSpace* colorSpace() const { return fColorSpace.get(); }
+
+ // Deprecated
SkColorProfileType profileType() const { return fProfileType; }
bool isEmpty() const { return fWidth <= 0 || fHeight <= 0; }
@@ -244,6 +252,7 @@ public:
return SkAlphaTypeIsOpaque(fAlphaType);
}
+ // Deprecated
bool isLinear() const { return kLinear_SkColorProfileType == fProfileType; }
bool isSRGB() const { return kSRGB_SkColorProfileType == fProfileType; }
@@ -255,15 +264,15 @@ public:
* but with the specified width and height.
*/
SkImageInfo makeWH(int newWidth, int newHeight) const {
- return SkImageInfo::Make(newWidth, newHeight, fColorType, fAlphaType, fProfileType);
+ return SkImageInfo(newWidth, newHeight, fColorType, fAlphaType, fProfileType, fColorSpace);
}
SkImageInfo makeAlphaType(SkAlphaType newAlphaType) const {
- return SkImageInfo::Make(fWidth, fHeight, fColorType, newAlphaType, fProfileType);
+ return SkImageInfo(fWidth, fHeight, fColorType, newAlphaType, fProfileType, fColorSpace);
}
SkImageInfo makeColorType(SkColorType newColorType) const {
- return SkImageInfo::Make(fWidth, fHeight, newColorType, fAlphaType, fProfileType);
+ return SkImageInfo(fWidth, fHeight, newColorType, fAlphaType, fProfileType, fColorSpace);
}
int bytesPerPixel() const { return SkColorTypeBytesPerPixel(fColorType); }
@@ -285,10 +294,14 @@ public:
}
bool operator==(const SkImageInfo& other) const {
- return 0 == memcmp(this, &other, sizeof(other));
+ return fWidth == other.fWidth && fHeight == other.fHeight &&
+ fColorType == other.fColorType && fAlphaType == other.fAlphaType &&
+ fProfileType == other.fProfileType && fColorSpace == other.fColorSpace;
}
bool operator!=(const SkImageInfo& other) const {
- return 0 != memcmp(this, &other, sizeof(other));
+ return fWidth != other.fWidth || fHeight != other.fHeight ||
+ fColorType != other.fColorType || fAlphaType != other.fAlphaType ||
+ fProfileType != other.fProfileType || fColorSpace != other.fColorSpace;
}
void unflatten(SkReadBuffer&);
@@ -322,13 +335,16 @@ private:
SkColorType fColorType;
SkAlphaType fAlphaType;
SkColorProfileType fProfileType;
+ sk_sp<SkColorSpace> fColorSpace;
- SkImageInfo(int width, int height, SkColorType ct, SkAlphaType at, SkColorProfileType pt)
+ SkImageInfo(int width, int height, SkColorType ct, SkAlphaType at, SkColorProfileType pt,
+ sk_sp<SkColorSpace> cs)
: fWidth(width)
, fHeight(height)
, fColorType(ct)
, fAlphaType(at)
, fProfileType(pt)
+ , fColorSpace(std::move(cs))
{}
};
« no previous file with comments | « include/codec/SkEncodedInfo.h ('k') | src/codec/SkCodec.cpp » ('j') | src/core/SkBitmap.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698