Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2000703002: [crankshaft] Don't inline "dont_crankshaft" functions (Closed)

Created:
4 years, 7 months ago by Jakob Kummerow
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Don't inline "dont_crankshaft" functions Crankshaft shouldn't try to inline functions it knows it can't handle. BUG=v8:5033 Committed: https://crrev.com/43547df9c7c32b102234b489aa2962e1b49b3744 Cr-Commit-Position: refs/heads/master@{#36417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-5033.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL. You'd think we'd have this check already...
4 years, 7 months ago (2016-05-20 14:03:10 UTC) #2
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-20 14:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000703002/1
4 years, 7 months ago (2016-05-20 14:29:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 15:18:55 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 15:20:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43547df9c7c32b102234b489aa2962e1b49b3744
Cr-Commit-Position: refs/heads/master@{#36417}

Powered by Google App Engine
This is Rietveld 408576698