Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000673003: Split out Members, Persistents and SelfKeepAlive in separate headers. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, oilpan-reviews, Mads Ager (chromium), mlamouri+watch-blink_chromium.org, blink-reviews-css, dcheng, haraken, loading-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, kinuko+watch, Nate Chapin, kouhei+heap_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split out Members, Persistents and SelfKeepAlive in separate headers. Slim down Handle.h and introduce separate header files for the Member<> Persistent<>s and SelfKeepAlive<> template classes, along with supporting definitions for those. R= BUG=

Patch Set 1 #

Patch Set 2 : Phase out blink::IsGarbageCollectedType<T> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+564 lines, -1714 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/OnStackObjectChecker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/OnStackObjectChecker.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 1 4 chunks +2 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 1 4 chunks +2 lines, -1107 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 chunks +24 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/Member.h View 1 1 chunk +328 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/heap/Persistent.h View 1 4 chunks +18 lines, -523 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/SelfKeepAlive.h View 1 chunk +83 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/blink_heap.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/SuspendableScriptExecutor.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 2 chunks +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypeTraits.h View 1 2 chunks +19 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698