Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: components/suggestions/suggestions_service.h

Issue 2000653002: Replace the usage of SkBitmap with gfx::Image in the suggestion service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace SkBitmap with gfx::Image in the suggestions_service interface Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service.h
diff --git a/components/suggestions/suggestions_service.h b/components/suggestions/suggestions_service.h
index 7c11f25fe7c16fd7f44fbe4961ea538be323e910..0a99af88130290682d242abf2d6a983cf50ec9d6 100644
--- a/components/suggestions/suggestions_service.h
+++ b/components/suggestions/suggestions_service.h
@@ -1,4 +1,4 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
Marc Treib 2016/05/20 14:40:04 nit: We don't update the copyright headers.
markusheintz_ 2016/05/23 13:20:47 Done.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -24,6 +24,10 @@
#include "net/url_request/url_fetcher_delegate.h"
#include "url/gurl.h"
+namespace gfx {
+class Image;
+}
+
namespace net {
class URLRequestContextGetter;
} // namespace net
@@ -38,7 +42,6 @@ class PrefRegistrySyncable;
class OAuth2TokenService;
class SigninManagerBase;
-class SkBitmap;
namespace suggestions {
@@ -52,7 +55,7 @@ class SuggestionsService : public KeyedService,
public sync_driver::SyncServiceObserver {
public:
using ResponseCallback = base::Callback<void(const SuggestionsProfile&)>;
- using BitmapCallback = base::Callback<void(const GURL&, const SkBitmap*)>;
+ using BitmapCallback = base::Callback<void(const GURL&, const gfx::Image&)>;
using ResponseCallbackList =
base::CallbackList<void(const SuggestionsProfile&)>;
« components/suggestions/image_manager.cc ('K') | « components/suggestions/image_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698