chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 2000653002: Replace the usage of SkBitmap with gfx::Image in the suggestion service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2000653002: Replace the usage of SkBitmap with gfx::Image in the suggestion service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: accidental up load. This patchset was not committed with this CL Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index a43fae171c508e8c986110431a40fb5d134ad923..98e8896dca9f69f440af684308ca61fa792b3744 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -52,7 +52,7 @@ import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge.SnippetsObserver;

import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;

-import org.chromium.chrome.browser.profiles.MostVisitedSites.ThumbnailCallback;

+//import org.chromium.chrome.browser.profiles.MostVisitedSites.ThumbnailCallback;

import org.chromium.chrome.browser.util.ViewUtils;

import org.chromium.chrome.browser.widget.RoundedIconGenerator;

import org.chromium.ui.base.DeviceFormFactor;

@@ -174,7 +174,7 @@ public class NewTabPageView extends FrameLayout

* @param url The URL whose thumbnail is being retrieved.

* @param thumbnailCallback The callback to be notified when the thumbnail is available.

- void getURLThumbnail(String url, ThumbnailCallback thumbnailCallback);

+// void getURLThumbnail(String url, ThumbnailCallback thumbnailCallback);

/**

* Gets the favicon image for a given URL.