Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2000643002: Revert of bindings: Supports [SameObject] extended attribute. (Closed)

Created:
4 years, 7 months ago by Yuki
Modified:
4 years, 4 months ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bindings: Supports [SameObject] extended attribute. (patchset #2 id:20001 of https://codereview.chromium.org/1980553002/ ) Reason for revert: This CL hits terrible performance regressions. Original issue's description: > bindings: Supports [SameObject] extended attribute. > > Syntactically we've supported [SameObject] extended attribute, > but we've not had any implementation for it. > > This CL stores the first returned value in the holder's > private value, and returns it for the second time. > > BUG=462913 > > Committed: https://crrev.com/40d19a73c02f0185e5a49c4761860762896dec28 > Cr-Commit-Position: refs/heads/master@{#393827} TBR=bashi@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=462913, 613172, 613170 Committed: https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4 Cr-Commit-Position: refs/heads/master@{#395064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -35 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/gc-9-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 3 chunks +3 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 5 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImportRule.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImportRule.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yuki
Created Revert of bindings: Supports [SameObject] extended attribute.
4 years, 7 months ago (2016-05-20 11:17:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000643002/1
4 years, 7 months ago (2016-05-20 11:20:11 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-20 11:24:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 13:34:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4 Cr-Commit-Position: refs/heads/master@{#395064}
4 years, 7 months ago (2016-05-20 13:35:39 UTC) #9
Will Harris
On 2016/05/20 13:35:39, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 4 months ago (2016-07-28 21:22:01 UTC) #10
Yuki
4 years, 4 months ago (2016-07-29 07:46:29 UTC) #11
Message was sent while issue was closed.
On 2016/07/28 21:22:01, Will Harris wrote:
> On 2016/05/20 13:35:39, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4
> > Cr-Commit-Position: refs/heads/master@{#395064}
> 
> this revert was made after 2743 branch point, was it also reverted on M52
branch
> 2743?

Oh, my!!  Thanks for catching this.
I'll request a merge to M52 on https://crbug.com/613172

Powered by Google App Engine
This is Rietveld 408576698