Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000563002: [DevTools] Attach all ServiceWorkers that match the origin. (Closed)

Created:
4 years, 7 months ago by horo
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Attach all ServiceWorkers that match the origin. BUG=613072 Committed: https://crrev.com/f4215d06fb2c4f27e3ba81a7089c4816ecc8dab1 Cr-Commit-Position: refs/heads/master@{#395085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.cc View 2 chunks +2 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
horo
Could you please review this?
4 years, 7 months ago (2016-05-20 10:39:58 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-20 15:51:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000563002/1
4 years, 7 months ago (2016-05-20 15:51:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 16:12:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 16:14:07 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f4215d06fb2c4f27e3ba81a7089c4816ecc8dab1
Cr-Commit-Position: refs/heads/master@{#395085}

Powered by Google App Engine
This is Rietveld 408576698