Source/core/rendering/RootInlineBox.cpp - Issue 200053007: Documents with many lines overallocated pagination info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RootInlineBox.cpp

Issue 200053007: Documents with many lines overallocated pagination info. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Simplified condition Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RootInlineBox.cpp

diff --git a/Source/core/rendering/RootInlineBox.cpp b/Source/core/rendering/RootInlineBox.cpp

index 3bcc6fd62bd62739c7a7072201df1d01d85148fe..c7c3536c2a6033fbeb9e0ce288de061d641bebf7 100644

--- a/Source/core/rendering/RootInlineBox.cpp

+++ b/Source/core/rendering/RootInlineBox.cpp

@@ -249,7 +249,9 @@ LayoutUnit RootInlineBox::alignBoxesInBlockDirection(LayoutUnit heightOfBlock, G

maxHeight = max<LayoutUnit>(0, maxHeight); // FIXME: Is this really necessary?

setLineTopBottomPositions(lineTop, lineBottom, heightOfBlock, heightOfBlock + maxHeight);

- setPaginatedLineWidth(block().availableLogicalWidthForContent());

+ bool paginated = block().view()->layoutState()->isPaginated();

mstensho (USE GERRIT) 2014/03/28 09:49:21 The 'paginated' variable seems rather unnecessary,

Daniel Bratell 2014/03/31 15:29:40 Done.

+ if (paginated)

+ setPaginatedLineWidth(block().availableLogicalWidthForContent());

LayoutUnit annotationsAdjustment = beforeAnnotationsAdjustment();

if (annotationsAdjustment) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »