Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: Source/devtools/front_end/NavigatorView.js

Issue 200053006: DevTools: Fix [bound] function receivers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 }, 400 },
401 401
402 /** 402 /**
403 * @param {!WebInspector.UISourceCode} uiSourceCode 403 * @param {!WebInspector.UISourceCode} uiSourceCode
404 * @param {boolean} deleteIfCanceled 404 * @param {boolean} deleteIfCanceled
405 */ 405 */
406 rename: function(uiSourceCode, deleteIfCanceled) 406 rename: function(uiSourceCode, deleteIfCanceled)
407 { 407 {
408 var node = this._uiSourceCodeNodes.get(uiSourceCode); 408 var node = this._uiSourceCodeNodes.get(uiSourceCode);
409 console.assert(node); 409 console.assert(node);
410 node.rename(callback); 410 node.rename(callback.bind(this));
aandrey 2014/03/19 09:57:59 this should not have worked at all. is this a dead
apavlov 2014/03/19 10:16:59 Nope. It does throw an exception when executed :-/
411 411
412 /** 412 /**
413 * @this {WebInspector.NavigatorView} 413 * @this {WebInspector.NavigatorView}
414 * @param {boolean} committed 414 * @param {boolean} committed
415 */ 415 */
416 function callback(committed) 416 function callback(committed)
417 { 417 {
418 if (!committed) { 418 if (!committed) {
419 if (deleteIfCanceled) 419 if (deleteIfCanceled)
420 uiSourceCode.remove(); 420 uiSourceCode.remove();
(...skipping 989 matching lines...) Expand 10 before | Expand all | Expand 10 after
1410 1410
1411 willRemoveChild: function(node) 1411 willRemoveChild: function(node)
1412 { 1412 {
1413 if (node._isMerged || !this.isPopulated()) 1413 if (node._isMerged || !this.isPopulated())
1414 return; 1414 return;
1415 this._treeElement.removeChild(node._treeElement); 1415 this._treeElement.removeChild(node._treeElement);
1416 }, 1416 },
1417 1417
1418 __proto__: WebInspector.NavigatorTreeNode.prototype 1418 __proto__: WebInspector.NavigatorTreeNode.prototype
1419 } 1419 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/IsolatedFileSystem.js ('k') | Source/devtools/front_end/PropertiesSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698