Issue 200053006: DevTools: Fix [bound] function receivers

Issue 200053006: DevTools: Fix [bound] function receivers (Closed)

Created:
6 years, 9 months ago by apavlov

Modified:
6 years, 9 months ago

Reviewers:
vsevik, aandrey

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Fix [bound] function receivers R=aandrey, vsevik NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169536

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -15 lines)			Patch
M	Source/devtools/front_end/IsolatedFileSystem.js	View	7 chunks	+9 lines, -8 lines	0 comments	Download
M	Source/devtools/front_end/NavigatorView.js	View	1 chunk	+1 line, -1 line	2 comments	Download
M	Source/devtools/front_end/PropertiesSidebarPane.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/UIUtils.js	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aandrey

lgtm https://codereview.chromium.org/200053006/diff/1/Source/devtools/front_end/NavigatorView.js File Source/devtools/front_end/NavigatorView.js (right): https://codereview.chromium.org/200053006/diff/1/Source/devtools/front_end/NavigatorView.js#newcode410 Source/devtools/front_end/NavigatorView.js:410: node.rename(callback.bind(this)); this should not have worked at all. ...

6 years, 9 months ago (2014-03-19 09:57:58 UTC) #2

apavlov

https://codereview.chromium.org/200053006/diff/1/Source/devtools/front_end/NavigatorView.js File Source/devtools/front_end/NavigatorView.js (right): https://codereview.chromium.org/200053006/diff/1/Source/devtools/front_end/NavigatorView.js#newcode410 Source/devtools/front_end/NavigatorView.js:410: node.rename(callback.bind(this)); On 2014/03/19 09:57:59, aandrey wrote: > this should ...

6 years, 9 months ago (2014-03-19 10:16:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/200053006/1

6 years, 9 months ago (2014-03-19 10:17:03 UTC) #5

Message was sent while issue was closed.

Change committed as 169536

Expand Messages | Collapse Messages