Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2000523003: Fully support read/write memory-mapped files for persistent memory. (Closed)

Created:
4 years, 7 months ago by bcwhite
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fully support read/write memory-mapped files for persistent memory. BUG=546019 Committed: https://crrev.com/34229a8a3ea34847268d5b9f7a6e69f6f961bbc5 Cr-Commit-Position: refs/heads/master@{#396313}

Patch Set 1 #

Patch Set 2 : minor test improvement #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -33 lines) Patch
M base/metrics/persistent_memory_allocator.h View 1 chunk +8 lines, -4 lines 0 comments Download
M base/metrics/persistent_memory_allocator.cc View 6 chunks +26 lines, -17 lines 0 comments Download
M base/metrics/persistent_memory_allocator_unittest.cc View 1 7 chunks +78 lines, -9 lines 0 comments Download
M components/metrics/file_metrics_provider.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bcwhite
4 years, 7 months ago (2016-05-20 16:31:29 UTC) #2
bcwhite
Ping?
4 years, 7 months ago (2016-05-26 13:39:40 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-26 20:10:59 UTC) #4
bcwhite
On 2016/05/26 20:10:59, Alexei Svitkine (slow) wrote: > lgtm No comments? Who are you and ...
4 years, 7 months ago (2016-05-26 20:52:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000523003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000523003/40001
4 years, 7 months ago (2016-05-26 20:53:24 UTC) #7
Alexei Svitkine (slow)
:P On Thu, May 26, 2016 at 4:53 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > ...
4 years, 7 months ago (2016-05-26 20:55:49 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-26 23:24:43 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 23:25:43 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/34229a8a3ea34847268d5b9f7a6e69f6f961bbc5
Cr-Commit-Position: refs/heads/master@{#396313}

Powered by Google App Engine
This is Rietveld 408576698