Remove the fingerprint and ca_fingerprint from X509Certificate

net/cert/nss_profile_filter_chromeos_unittest.cc

Index: net/cert/nss_profile_filter_chromeos_unittest.cc
diff --git a/net/cert/nss_profile_filter_chromeos_unittest.cc b/net/cert/nss_profile_filter_chromeos_unittest.cc
index f0243d843daf758eabce506a797ff272ffb44f63..cf446665925c26d7e6229e72c1269f7511d884b7 100644
--- a/net/cert/nss_profile_filter_chromeos_unittest.cc
+++ b/net/cert/nss_profile_filter_chromeos_unittest.cc
@@ -7,12 +7,15 @@
 #include <cert.h>
 #include <pk11pub.h>
 #include <secmod.h>
+
+#include <algorithm>
 #include <utility>
 
 #include "crypto/nss_util_internal.h"
 #include "crypto/scoped_nss_types.h"
 #include "crypto/scoped_test_nss_chromeos_user.h"
 #include "crypto/scoped_test_nss_db.h"
+#include "net/base/hash_value.h"
 #include "net/base/test_data_directory.h"
 #include "net/test/cert_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -49,7 +52,14 @@ CertificateList ListCertsInSlot(PK11SlotInfo* slot) {
   CERT_DestroyCertList(cert_list);
 
   // Sort the result so that test comparisons can be deterministic.
-  std::sort(result.begin(), result.end(), X509Certificate::LessThan());
+  std::sort(

[eroman, 2016/06/09 22:18:25]

Consider extracting this to something like net/test/cert_test_util.h, as it is
used in a few places.

Duplicating is fine too given the brevity.

[Ryan Sleevi, 2016/06/09 22:59:36]

Yeah, I opted for duplication as a discouragement from doing this without having
to do the mental overhead of switching to GMock which handles this :)

+      result.begin(), result.end(),
+      [](const scoped_refptr<X509Certificate>& lhs,
+         const scoped_refptr<X509Certificate>& rhs) {
+        return SHA256HashValueLessThan()(
+            X509Certificate::CalculateFingerprint256(lhs->os_cert_handle()),
+            X509Certificate::CalculateFingerprint256(rhs->os_cert_handle()));
+      });
   return result;
 }