Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: content/browser/cert_store_impl.h

Issue 2000503002: Remove the fingerprint and ca_fingerprint from X509Certificate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_cache
Patch Set: Fix IDN test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_certificate_importer_impl_unittest.cc ('k') | content/browser/cert_store_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/cert_store_impl.h
diff --git a/content/browser/cert_store_impl.h b/content/browser/cert_store_impl.h
index 2b08c52c802cb03ddf718ec714cb46ee54a2b33f..b4ef08c00446c45a668c6b9ffba374c66288683e 100644
--- a/content/browser/cert_store_impl.h
+++ b/content/browser/cert_store_impl.h
@@ -6,9 +6,11 @@
#define CONTENT_BROWSER_CERT_STORE_IMPL_H_
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/singleton.h"
#include "content/browser/renderer_data_memoizing_store.h"
#include "content/public/browser/cert_store.h"
+#include "net/base/hash_value.h"
#include "net/cert/x509_certificate.h"
namespace content {
@@ -31,7 +33,30 @@ class CertStoreImpl : public CertStore {
private:
friend struct base::DefaultSingletonTraits<CertStoreImpl>;
- RendererDataMemoizingStore<net::X509Certificate> store_;
+ // Utility structure that allows memoization to be based on the
+ // hash of |cert|'s certificate chain, to avoid needing to compare
+ // every certificate individually. This is purely an optimization.
+ class HashAndCert : public base::RefCountedThreadSafe<HashAndCert> {
+ public:
+ HashAndCert();
+
+ // Comparator for RendererDataMemoizingStore.
+ struct LessThan {
+ bool operator()(const scoped_refptr<HashAndCert>& lhs,
+ const scoped_refptr<HashAndCert>& rhs) const;
+ };
+
+ net::SHA256HashValue chain_hash;
+ scoped_refptr<net::X509Certificate> cert;
+
+ private:
+ friend class base::RefCountedThreadSafe<HashAndCert>;
+
+ ~HashAndCert();
+
+ DISALLOW_COPY_AND_ASSIGN(HashAndCert);
+ };
+ RendererDataMemoizingStore<HashAndCert> store_;
DISALLOW_COPY_AND_ASSIGN(CertStoreImpl);
};
« no previous file with comments | « chromeos/network/onc/onc_certificate_importer_impl_unittest.cc ('k') | content/browser/cert_store_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698