chrome/browser/ssl/ssl_browser_tests.cc - Issue 2000503002: Remove the fingerprint and ca_fingerprint from X509Certificate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2000503002: Remove the fingerprint and ca_fingerprint from X509Certificate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_cache

Patch Set: Fix IDN test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chromeos/network/onc/onc_certificate_importer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index bb671dbce6e05eef4a5faba5d8ce0d2b3db952e9..658958394a5f17af3ede8d8443f226e9cd1f8352 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -2983,8 +2983,8 @@ class SSLBlockingPageIDNTest : public SecurityInterstitialIDNTest {

content::WebContents* contents,

const GURL& request_url) const override {

net::SSLInfo ssl_info;

- ssl_info.cert = new net::X509Certificate(

- request_url.host(), "CA", base::Time::Max(), base::Time::Max());

+ ssl_info.cert =

+ net::ImportCertFromFile(net::GetTestCertsDirectory(), "ok_cert.pem");

return new SSLBlockingPage(

contents, net::ERR_CERT_CONTAINS_ERRORS, ssl_info, request_url, 0,

base::Time::NowFromSystemTime(), nullptr, base::Callback<void(bool)>());