Clean up V8 bindings template code

Clean up V8 bindings template code

This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

TBR=chasej@chromium.org

Committed: https://crrev.com/b96196730f9ca3f02a60c3e59b58b61bf5c50def
Cr-Commit-Position: refs/heads/master@{#395067}

[iclelland, 2016-05-20 04:26:48]

iclelland@chromium.org changed reviewers:
+ chasej@chromium.org, haraken@chromium.org

[iclelland, 2016-05-20 04:26:48]

haraken, PTAL, thanks!
chasej, FYI

There was a lot of logic written directly in the templates that is much more
clearly written using filters, and having any complexity defined in a single
place (in Python, preferably)

There is almost certainly more work to be done in this are, but these changes
make it much easier to refactor the RuntimeEnabled and OriginTrialEnabled code
(in upcoming CLs)

[haraken, 2016-05-20 04:43:37]

This looks like a nice refactoring. LGTM.

[Yuki, 2016-05-20 06:10:10]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-05-20 06:10:10]

LGTM!!

[iclelland, 2016-05-20 12:47:13]

The CQ bit was checked by iclelland@chromium.org

[commit-bot: I haz the power, 2016-05-20 12:47:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000483002/1

[iclelland, 2016-05-20 12:48:11]

The CQ bit was unchecked by iclelland@chromium.org

[iclelland, 2016-05-20 12:48:29]

Description was changed from

==========
Clean up V8 bindings template code

This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

BUG=
==========

to

==========
Clean up V8 bindings template code

This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

TBR=chasej@chromium.org
==========

[iclelland, 2016-05-20 12:48:39]

The CQ bit was checked by iclelland@chromium.org

[commit-bot: I haz the power, 2016-05-20 12:48:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000483002/1

[commit-bot: I haz the power, 2016-05-20 13:48:22]

Description was changed from

==========
Clean up V8 bindings template code

This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

TBR=chasej@chromium.org
==========

to

==========
Clean up V8 bindings template code

This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

TBR=chasej@chromium.org
==========

[commit-bot: I haz the power, 2016-05-20 13:48:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-20 13:49:34]

Description was changed from

==========
Clean up V8 bindings template code

This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

TBR=chasej@chromium.org
==========

to

==========
Clean up V8 bindings template code

This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

TBR=chasej@chromium.org

Committed: https://crrev.com/b96196730f9ca3f02a60c3e59b58b61bf5c50def
Cr-Commit-Position: refs/heads/master@{#395067}
==========

[commit-bot: I haz the power, 2016-05-20 13:49:35]

Patchset 1 (id:??) landed as
https://crrev.com/b96196730f9ca3f02a60c3e59b58b61bf5c50def
Cr-Commit-Position: refs/heads/master@{#395067}