Clamp AudioParam automations to the nominal range.

Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/766
Resolution: https://github.com/WebAudio/web-audio-api/pull/808

BUG=604827
TEST=audioparam-automation-clamping.html

Committed: https://crrev.com/d37fd97295ac7f7c3a5112f707ff51216f55fbbf
Cr-Commit-Position: refs/heads/master@{#400599}

[Raymond Toy, 2016-06-13 17:59:29]

Description was changed from

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

BUG=604827
TEST=
==========

to

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

BUG=604827
TEST=/audioparam-automation-clamping.html
==========

[Raymond Toy, 2016-06-15 20:11:09]

Description was changed from

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

BUG=604827
TEST=/audioparam-automation-clamping.html
==========

to

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

BUG=604827
TEST=audioparam-automation-clamping.html
==========

[Raymond Toy, 2016-06-15 20:17:18]

Description was changed from

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

BUG=604827
TEST=audioparam-automation-clamping.html
==========

to

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/766
Resolution: https://github.com/WebAudio/web-audio-api/pull/808

BUG=604827
TEST=audioparam-automation-clamping.html
==========

[Raymond Toy, 2016-06-17 16:23:19]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-06-17 16:23:20]

PTAL.

[hongchan, 2016-06-17 17:00:41]

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp (right):

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:380: }
Sorry to bring this up again, why this pattern is different form the line
342~348? This mutex is active until this method is finished.

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:388: return
lastValue;
Are these safe outside of tryLock?

[Raymond Toy, 2016-06-17 17:10:06]

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp (right):

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:380: }
On 2016/06/17 17:00:40, hoch wrote:
> Sorry to bring this up again, why this pattern is different form the line
> 342~348? This mutex is active until this method is finished.

I didn't actually change this.  Are you saying I should?

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:388: return
lastValue;
On 2016/06/17 17:00:40, hoch wrote:
> Are these safe outside of tryLock?

I didn't really change the thread safety here.  It should be as safe (or unsafe)
as before.

[hongchan, 2016-06-17 17:55:06]

lgtm

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp (right):

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:380: }
On 2016/06/17 17:10:05, Raymond Toy wrote:
> On 2016/06/17 17:00:40, hoch wrote:
> > Sorry to bring this up again, why this pattern is different form the line
> > 342~348? This mutex is active until this method is finished.
> 
> I didn't actually change this.  Are you saying I should?

Disregard my comment. They are different, but looks okay here.

https://codereview.chromium.org/2000423008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:388: return
lastValue;
On 2016/06/17 17:10:05, Raymond Toy wrote:
> On 2016/06/17 17:00:40, hoch wrote:
> > Are these safe outside of tryLock?
> 
> I didn't really change the thread safety here.  It should be as safe (or
unsafe)
> as before.

I misundstood the scope of tryLock. This looks safe.

[Raymond Toy, 2016-06-17 18:25:18]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-06-17 18:25:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000423008/40001

[commit-bot: I haz the power, 2016-06-17 21:41:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 21:41:50]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2016-06-18 15:46:11]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-06-18 15:46:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000423008/40001

[commit-bot: I haz the power, 2016-06-18 20:52:01]

Description was changed from

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/766
Resolution: https://github.com/WebAudio/web-audio-api/pull/808

BUG=604827
TEST=audioparam-automation-clamping.html
==========

to

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/766
Resolution: https://github.com/WebAudio/web-audio-api/pull/808

BUG=604827
TEST=audioparam-automation-clamping.html
==========

[commit-bot: I haz the power, 2016-06-18 20:52:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-18 20:53:29]

Description was changed from

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/766
Resolution: https://github.com/WebAudio/web-audio-api/pull/808

BUG=604827
TEST=audioparam-automation-clamping.html
==========

to

==========
Clamp AudioParam automations to the nominal range.

AudioParam automations should clamp the values to the nominal ranges.
The clamping should happen just before the values are applied.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/766
Resolution: https://github.com/WebAudio/web-audio-api/pull/808

BUG=604827
TEST=audioparam-automation-clamping.html

Committed: https://crrev.com/d37fd97295ac7f7c3a5112f707ff51216f55fbbf
Cr-Commit-Position: refs/heads/master@{#400599}
==========

[commit-bot: I haz the power, 2016-06-18 20:53:30]

Patchset 3 (id:??) landed as
https://crrev.com/d37fd97295ac7f7c3a5112f707ff51216f55fbbf
Cr-Commit-Position: refs/heads/master@{#400599}