Complex clipPath accounting

Complex clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org,bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005

Committed: https://skia.googlesource.com/skia/+/b5fc58e1de6c2428f786034262a2ecdc8388d21d

[f(malita), 2016-05-25 02:15:28]

Description was changed from

==========
Slow clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to allow external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org
==========

to

==========
Slow clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to allow external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

[f(malita), 2016-05-25 02:17:49]

Description was changed from

==========
Slow clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to allow external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

to

==========
Slow clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

[f(malita), 2016-05-25 02:25:16]

Description was changed from

==========
Slow clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

to

==========
Complex clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

[f(malita), 2016-05-25 02:28:08]

Description was changed from

==========
Complex clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

to

==========
Complex clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org,bsalomon@google...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

[f(malita), 2016-05-25 02:28:08]

fmalita@chromium.org changed reviewers:
+ bsalomon@google.com

[f(malita), 2016-05-25 02:35:58]

(tentative take on https://bugs.chromium.org/p/skia/issues/detail?id=5347)

Rather than converting SkPictureGpuAnalyzer to a full-blown canvas API to
support arbitrary draw ops, how about exposing the needed entry points
piecemeal?  This doesn't seem intrusive and I don't expect the number of
interesting external ops to be significant (can't really think of anything
besides clipPath at this point).

The corresponding CC hookup: https://codereview.chromium.org/2013723002/

[mtklein, 2016-05-25 13:26:49]

quite lgtm

https://codereview.chromium.org/2000423005/diff/1/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/2000423005/diff/1/tests/PictureTest.cpp#newco...
tests/PictureTest.cpp:138: static SkPath MakeConvexPath() {
static functions are usually named like make_convex_path(), make_concave_path()

[f(malita), 2016-05-25 14:42:49]

https://codereview.chromium.org/2000423005/diff/1/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/2000423005/diff/1/tests/PictureTest.cpp#newco...
tests/PictureTest.cpp:138: static SkPath MakeConvexPath() {
On 2016/05/25 13:26:49, mtklein wrote:
> static functions are usually named like make_convex_path(),
make_concave_path()

Done.

[f(malita), 2016-05-25 14:43:33]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 14:43:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000423005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000423005/20001

[commit-bot: I haz the power, 2016-05-25 14:53:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 14:53:26]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[Stephen White, 2016-05-25 17:38:46]

LGTM

[reed1, 2016-05-25 17:41:23]

brian is not around today, but lets land it anyway and can discuss w/ him
tomorrow as needed.

lgtm

[f(malita), 2016-05-25 18:23:16]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-05-25 18:23:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2000423005/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-05-25 18:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000423005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000423005/20001

[commit-bot: I haz the power, 2016-05-25 18:31:11]

Description was changed from

==========
Complex clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org,bsalomon@google...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005
==========

to

==========
Complex clipPath accounting

Add a clipPath heuristic to SkPathCounter, and extend
SkPictureGpuAnalyzer to support external clipPath() op accounting.

BUG=skia:5347
R=reed@google.com,mtklein@google.com,senorblanco@chromium.org,bsalomon@google...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2000423005

Committed:
https://skia.googlesource.com/skia/+/b5fc58e1de6c2428f786034262a2ecdc8388d21d
==========

[commit-bot: I haz the power, 2016-05-25 18:31:12]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b5fc58e1de6c2428f786034262a2ecdc8388d21d