bot_update: remove activation check for non-masters

bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
if --master is not passed, which is the case in buildbotless world

R=hinoka@chromium.org, iannucci@chromium.org
BUG=613641
Committed: https://chromium.googlesource.com/chromium/tools/build/+/d9934015cab19dc4f1e31906b6caaadf4d392942

[nodir, 2016-05-24 17:18:15]

PTAL

[nodir, 2016-05-24 17:22:58]

Description was changed from

==========
bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
for that case.

R=hinoka@chromium.org, iannucci@chromium.org
BUG=
==========

to

==========
bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
if --master is not passed, which is the case in buildbotless world

R=hinoka@chromium.org, iannucci@chromium.org
BUG=
==========

[nodir, 2016-05-24 17:55:45]

Description was changed from

==========
bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
if --master is not passed, which is the case in buildbotless world

R=hinoka@chromium.org, iannucci@chromium.org
BUG=
==========

to

==========
bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
if --master is not passed, which is the case in buildbotless world

R=hinoka@chromium.org, iannucci@chromium.org
BUG=613641
==========

[hinoka, 2016-05-24 19:36:24]

https://codereview.chromium.org/2000403004/diff/1/scripts/slave/bot_update.py
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/2000403004/diff/1/scripts/slave/bot_update.py...
scripts/slave/bot_update.py:1688: master = options.master
What about just
if not master:
  options.force = True

And then rearrange 1691 so that it's options.force or check_valid_host() ...

[hinoka, 2016-05-24 19:41:37]

fwiw, i had a plan to add in a bot_update_lite which removes most of the
bot_update cruft.  But if this was the only thing blocking you then nvm.
https://codereview.chromium.org/1954833002/

[nodir, 2016-05-27 18:07:40]

https://codereview.chromium.org/2000403004/diff/1/scripts/slave/bot_update.py
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/2000403004/diff/1/scripts/slave/bot_update.py...
scripts/slave/bot_update.py:1688: master = options.master
On 2016/05/24 19:36:23, hinoka wrote:
> What about just
> if not master:
>   options.force = True
> 
> And then rearrange 1691 so that it's options.force or check_valid_host() ...

Done

[Ryan Tseng, 2016-05-27 18:43:47]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2016-05-27 18:43:48]

lgtm

[nodir, 2016-05-27 18:46:23]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-05-27 18:46:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000403004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000403004/20001

[commit-bot: I haz the power, 2016-05-27 18:53:23]

Description was changed from

==========
bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
if --master is not passed, which is the case in buildbotless world

R=hinoka@chromium.org, iannucci@chromium.org
BUG=613641
==========

to

==========
bot_update: remove activation check for non-masters

Activation check was useful when transitioning buildbot masters to
bot_update. It is not needed in buidlbotless world. Disable the check
if --master is not passed, which is the case in buildbotless world

R=hinoka@chromium.org, iannucci@chromium.org
BUG=613641

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d9934015cab19dc4f1e3...
==========

[commit-bot: I haz the power, 2016-05-27 18:53:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/d9934015cab19dc4f1e3...