Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: content/public/common/common_param_traits_macros.h

Issue 2000403003: [forbots] IWYU for ax_enums.h Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/common_param_traits_macros.h
diff --git a/content/public/common/common_param_traits_macros.h b/content/public/common/common_param_traits_macros.h
index d286acb321b53c56213d455d720b732e914470b6..ff2df17276b27d4dedd05fa2f1cfbf3e6f4eb67e 100644
--- a/content/public/common/common_param_traits_macros.h
+++ b/content/public/common/common_param_traits_macros.h
@@ -25,6 +25,7 @@
#include "third_party/WebKit/public/platform/modules/permissions/permission_status.mojom.h"
#include "third_party/WebKit/public/web/WebFrameSerializerCacheControlPolicy.h"
#include "third_party/WebKit/public/web/WebWindowFeatures.h"
+#include "ui/accessibility/ax_enums.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/accessibility/ax_tree_update.h"
#include "ui/base/page_transition_types.h"
@@ -262,6 +263,10 @@ IPC_STRUCT_TRAITS_BEGIN(blink::WebWindowFeatures)
IPC_STRUCT_TRAITS_MEMBER(dialog)
IPC_STRUCT_TRAITS_END()
+// TODO(tapted): Listing these requires exposing ax_enums.h which is a generated
+// header. This is problematic since it requires any target including this file
+// to depend directly on ax_gen to ensure the header exists, before attempting
+// to compile any files in that target.
IPC_ENUM_TRAITS_MAX_VALUE(ui::AXEvent, ui::AX_EVENT_LAST)
IPC_ENUM_TRAITS_MAX_VALUE(ui::AXRole, ui::AX_ROLE_LAST)
IPC_ENUM_TRAITS_MAX_VALUE(ui::AXBoolAttribute, ui::AX_BOOL_ATTRIBUTE_LAST)
« no previous file with comments | « content/public/browser/ax_event_notification_details.cc ('k') | content/renderer/accessibility/blink_ax_enum_conversion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698