experimental/PdfViewer/SkPdfFont.cpp - Issue 20004007: pdfviewer: don't crash if the xref is corrupted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/SkPdfFont.cpp

Issue 20004007: pdfviewer: don't crash if the xref is corrupted. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: experimental/PdfViewer/SkPdfFont.cpp

===================================================================

--- experimental/PdfViewer/SkPdfFont.cpp (revision 10286)

+++ experimental/PdfViewer/SkPdfFont.cpp (working copy)

@@ -197,7 +197,7 @@

// TODO(edisonn): perf - make a map

for (unsigned int i = 0 ; i < doc->objects(); i++) {

SkPdfObject* obj = doc->object(i);

- if (!obj->isDictionary()) {

+ if (!obj || !obj->isDictionary()) {

continue;

}

« no previous file with comments | « no previous file | experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp » ('j') | no next file with comments »