Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2416)

Unified Diff: ash/shelf/shelf_widget.h

Issue 2000393003: ash: Reorder shutdown of ShelfLayoutManager and StatusAreaWidget (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_tooltip_manager.cc ('k') | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_widget.h
diff --git a/ash/shelf/shelf_widget.h b/ash/shelf/shelf_widget.h
index 2a63c8d240cee749840932ace3e8ca60a72a0d12..6013414bb7c1ea16044362482b10c6782888466c 100644
--- a/ash/shelf/shelf_widget.h
+++ b/ash/shelf/shelf_widget.h
@@ -75,8 +75,8 @@ class ASH_EXPORT ShelfWidget : public views::Widget,
aura::Window* window_container() { return window_container_; }
- // TODO(harrym): Remove when Status Area Widget is a child view.
- void ShutdownStatusAreaWidget();
+ // Clean up prior to deletion.
+ void Shutdown();
// Force the shelf to be presented in an undimmed state.
void ForceUndimming(bool force);
@@ -96,11 +96,12 @@ class ASH_EXPORT ShelfWidget : public views::Widget,
void DisableDimmingAnimationsForTest();
// ShelfLayoutManagerObserver overrides:
- void WillDeleteShelf() override;
+ void WillDeleteShelfLayoutManager() override;
private:
class DelegateView;
+ // Owned by the shelf container's aura::Window.
ShelfLayoutManager* shelf_layout_manager_;
std::unique_ptr<Shelf> shelf_;
StatusAreaWidget* status_area_widget_;
« no previous file with comments | « ash/shelf/shelf_tooltip_manager.cc ('k') | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698