Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2000373004: Revert of Disable testPressNextFromEditTextAndType webview test (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
boliu, ssid
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable testPressNextFromEditTextAndType webview test (patchset #3 id:40001 of https://codereview.chromium.org/1978093002/ ) Reason for revert: Android GN is gone. Original issue's description: > Disable testPressNextFromEditTextAndType webview test > > The Android GN bot is broken. So disabling this test for now. > > BUG=611928 > > Committed: https://crrev.com/922b6a34547fd24f69a4adb5092b5c488c8aea38 > Cr-Commit-Position: refs/heads/master@{#393724} TBR=boliu@chromium.org,ssid@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=611928 Committed: https://crrev.com/4542ad283b4659bdee20b139997fe98b7ef06d22 Cr-Commit-Position: refs/heads/master@{#395590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jbudorick
Created Revert of Disable testPressNextFromEditTextAndType webview test
4 years, 6 months ago (2016-05-24 12:48:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000373004/1
4 years, 6 months ago (2016-05-24 12:48:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000373004/1
4 years, 6 months ago (2016-05-24 13:00:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000373004/1
4 years, 6 months ago (2016-05-24 13:31:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-24 13:49:17 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-24 13:50:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4542ad283b4659bdee20b139997fe98b7ef06d22
Cr-Commit-Position: refs/heads/master@{#395590}

Powered by Google App Engine
This is Rietveld 408576698