Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2000333003: Allow test and unittest_apk GN targets to use proguard (Closed)

Created:
4 years, 7 months ago by huapengl
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow test and unittest_apk GN targets to use proguard This CL adds proguard arguments to test and unittest_apk GN targets. This does not change the default behavior for these two targets. BUG=359249 Committed: https://crrev.com/c35ba6ea4eee6e6b0bb87c4048e357edf3d9b4a4 Cr-Commit-Position: refs/heads/master@{#396031}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove the "+" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 1 chunk +6 lines, -0 lines 0 comments Download
M testing/test.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
huapengl
Hi Dirk, Can you take a look on this change? Thanks
4 years, 7 months ago (2016-05-23 23:06:40 UTC) #2
Dirk Pranke
https://codereview.chromium.org/2000333003/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/2000333003/diff/1/build/config/android/rules.gni#newcode2140 build/config/android/rules.gni:2140: proguard_configs += invoker.proguard_configs shouldn't this be "proguard_configs = invoker.proguard_configs"?
4 years, 7 months ago (2016-05-24 22:07:15 UTC) #3
huapengl
On 2016/05/24 22:07:15, Dirk Pranke (slow) wrote: > https://codereview.chromium.org/2000333003/diff/1/build/config/android/rules.gni > File build/config/android/rules.gni (right): > > ...
4 years, 7 months ago (2016-05-25 20:47:51 UTC) #4
huapengl
removed the "+"
4 years, 7 months ago (2016-05-25 20:49:05 UTC) #5
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-25 21:20:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000333003/20001
4 years, 7 months ago (2016-05-25 21:23:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 23:08:18 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:10:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c35ba6ea4eee6e6b0bb87c4048e357edf3d9b4a4
Cr-Commit-Position: refs/heads/master@{#396031}

Powered by Google App Engine
This is Rietveld 408576698