Change the predicate used to identify editable text used for jump commands.

Change the predicate used to identify editable text used for jump commands.

BUG=613786
TEST=manual

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8182918362e0441d206f6f98d3572b7f2886d1d7
Cr-Commit-Position: refs/heads/master@{#395630}

[David Tseng, 2016-05-23 21:07:29]

Description was changed from

==========
Change the predicate used to identify editable text used for jump commands.
==========

to

==========
Change the predicate used to identify editable text used for jump commands.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-23 21:08:48]

Description was changed from

==========
Change the predicate used to identify editable text used for jump commands.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Change the predicate used to identify editable text used for jump commands.

BUG=613786
TEST=manual

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-23 21:08:48]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-05-23 23:00:54]

Note that the editable flag is set for the whole subtree of a text field,
especially a contenteditable. Will this do the right thing?

How about editable + focusable?

Or editable + focusable and !parent.editable?

[David Tseng, 2016-05-23 23:59:24]

PTAL. Done.

On Mon, May 23, 2016 at 4:00 PM, <dmazzoni@chromium.org> wrote:

> Note that the editable flag is set for the whole subtree of a text field,
> especially a contenteditable. Will this do the right thing?
>
> How about editable + focusable?
>
> Or editable + focusable and !parent.editable?
>
>
>
> https://codereview.chromium.org/2000333002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-05-24 16:55:38]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-05-24 16:55:38]

lgtm

[commit-bot: I haz the power, 2016-05-24 16:55:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000333002/20001

[commit-bot: I haz the power, 2016-05-24 17:38:52]

Description was changed from

==========
Change the predicate used to identify editable text used for jump commands.

BUG=613786
TEST=manual

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Change the predicate used to identify editable text used for jump commands.

BUG=613786
TEST=manual

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-24 17:38:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-24 17:40:55]

Description was changed from

==========
Change the predicate used to identify editable text used for jump commands.

BUG=613786
TEST=manual

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Change the predicate used to identify editable text used for jump commands.

BUG=613786
TEST=manual

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8182918362e0441d206f6f98d3572b7f2886d1d7
Cr-Commit-Position: refs/heads/master@{#395630}
==========

[commit-bot: I haz the power, 2016-05-24 17:40:56]

Patchset 2 (id:??) landed as
https://crrev.com/8182918362e0441d206f6f98d3572b7f2886d1d7
Cr-Commit-Position: refs/heads/master@{#395630}