Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2000323008: Use original repaint tests for spv2 (Closed)

Created:
2 years, 12 months ago by Xianzhu
Modified:
2 years, 12 months ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, ajuma+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, jbroman+watch_chromium.org, danakj+watch_chromium.org, pdr+virtualspv2watchlist_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-layers+watch_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use original repaint tests for spv2 We'll still need rect-based paint invalidation for spv2 at least for some time, and repaint tests for spv1 have been modified to be suitable for spv2, so remove paint/invalidation/spv2 (will be in a separate CL to reduce size of this one) and run the original repaint tests for spv2. BUG=524134 Committed: https://crrev.com/37a1670d01b4198536bb6fc2bc045e3db65bc7bb Cr-Commit-Position: refs/heads/master@{#396291}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -93 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +19 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/spv2/fast/repaint/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 1 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
2 years, 12 months ago (2016-05-26 17:39:31 UTC) #2
pdr.
On 2016/05/26 at 17:39:31, wangxianzhu wrote: > LGTM
2 years, 12 months ago (2016-05-26 21:41:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000323008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000323008/20001
2 years, 12 months ago (2016-05-26 21:43:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
2 years, 12 months ago (2016-05-26 21:55:07 UTC) #6
commit-bot: I haz the power
2 years, 12 months ago (2016-05-26 21:57:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37a1670d01b4198536bb6fc2bc045e3db65bc7bb
Cr-Commit-Position: refs/heads/master@{#396291}

Powered by Google App Engine
This is Rietveld 408576698