|
Revert of Create libsampler as V8 sampler library. (patchset #24 id:460001 of https://codereview.chromium.org/1922303002/ )
Reason for revert:
V8 Linux64 TSAN failure because ThreadSanitizer indicated data race.
Original issue's description:
> Create libsampler as V8 sampler library.
>
> This patch does five things:
>
> 1. Extracts sampler as libsampler to provide sampling functionality support.
> 2. Makes SampleStack virtual so embedders can override the behaviour of sample collecting.
> 3. Removes sampler.[h|cc].
> 4. Moves sampling thread into log.cc as workaround to keep the --prof functionality.
> 5. Creates SamplerManager to manage the relationship between samplers and threads.
>
> The reason we port hashmap.h is that in debug mode, STL containers are using
> mutexes from a mutex pool, which may lead to deadlock when using asynchronously
> signal handler.
>
> Currently libsampler is used in V8 temporarily.
>
> BUG= v8:4789
> LOG=n
>
> Committed: https://crrev.com/06cc9b7c176a6223971deaa9fbcafe1a05058c7b
> Cr-Commit-Position: refs/heads/master@{#36527}
TBR=jochen@chromium.org,alph@chromium.org,fmeawad@chromium.org,yangguo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= v8:4789
Committed: https://crrev.com/636f1e8e591dde3d71c45740ceda95ceb592cb0e
Cr-Commit-Position: refs/heads/master@{#36529}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+964 lines, -1380 lines) |
Patch |
|
M |
BUILD.gn
|
View
|
|
4 chunks |
+2 lines, -23 lines |
0 comments
|
Download
|
|
M |
include/v8.h
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/api.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/isolate.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
D |
src/libsampler/DEPS
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
D |
src/libsampler/hashmap.h
|
View
|
|
1 chunk |
+0 lines, -278 lines |
0 comments
|
Download
|
|
D |
src/libsampler/utils.h
|
View
|
|
1 chunk |
+0 lines, -27 lines |
0 comments
|
Download
|
|
D |
src/libsampler/v8-sampler.h
|
View
|
|
1 chunk |
+0 lines, -103 lines |
0 comments
|
Download
|
|
D |
src/libsampler/v8-sampler.cc
|
View
|
|
1 chunk |
+0 lines, -678 lines |
0 comments
|
Download
|
|
M |
src/log.h
|
View
|
|
3 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
|
M |
src/log.cc
|
View
|
|
5 chunks |
+10 lines, -60 lines |
0 comments
|
Download
|
|
M |
src/profiler/cpu-profiler.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/profiler/cpu-profiler.cc
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
A |
src/profiler/sampler.h
|
View
|
|
1 chunk |
+108 lines, -0 lines |
0 comments
|
Download
|
|
A |
src/profiler/sampler.cc
|
View
|
|
1 chunk |
+828 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/v8.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/v8.gyp
|
View
|
|
3 chunks |
+2 lines, -33 lines |
0 comments
|
Download
|
|
M |
test/cctest/cctest.gyp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
D |
test/cctest/libsampler/test-sampler.cc
|
View
|
|
1 chunk |
+0 lines, -141 lines |
0 comments
|
Download
|
|
M |
test/cctest/test-cpu-profiler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 11 (4 generated)
|