Make CompilerTask independent of compiler.

Make CompilerTask independent of compiler.

Now this base class only has logic for measuring time.

R=het@google.com, johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/b741e3f0df61662984e836c17bafe143c0b90c71

[Siggi Cherem (dart-lang), 2016-05-25 00:47:15]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-05-25 00:54:09]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2016-05-25 01:37:21]

Patchset #1 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2016-05-25 01:39:24]

Patchset #1 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2016-05-25 01:45:16]

sigmund@google.com changed reviewers:
+ het@google.com, johnniwinther@google.com

[Siggi Cherem (dart-lang), 2016-05-25 01:45:18]

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/tasks.dart (left):

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:16: class DeferredTask {
this is unrelated to the other kind of task, I moved this to the enqueuer, which
is the only place where it was used.

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (left):

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:252: GenericTask reuseLibraryTask;
now measured as a subtask of the loader

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:268: static const String
CREATE_INVOCATION_MIRROR = 'createInvocationMirror';
only used in one place, no reason to have it here...

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:347: new DietParserTask(this, options,
idGenerator, backend, reporter),
now diet parser and scanner below no longer need a compiler as an arg. woohoo!

[Johnni Winther, 2016-05-25 09:02:00]

lgtm

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/tasks.dart (left):

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:16: class DeferredTask {
On 2016/05/25 01:45:17, Siggi Cherem (dart-lang) wrote:
> this is unrelated to the other kind of task, I moved this to the enqueuer,
which
> is the only place where it was used.

Acknowledged.

[Harry Terkelsen, 2016-05-25 15:51:36]

lgtm

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/tasks.dart (right):

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:12: /// This exposes [measure] and
[measureIo], which wrap an action and assotiate
assotiate -> associate

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:13: /// the time spend during that action
with this task. Nested measurements can be
spend -> spent

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:32: // Note: it would be sufficient to
mark this getter abstract if we had enough
this note seems more like a TODO

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:56: /// Perform [action] and use [_watch]
to measure its runtime (including any
maybe remove the part about _watch in the docs since it's an implementation
detail. Just "perform action and measure..."

[Siggi Cherem (dart-lang), 2016-05-25 16:11:13]

Description was changed from

==========
Make CompilerTask independent of compiler.

Now this base class only has logic for measuring time.
==========

to

==========
Make CompilerTask independent of compiler.

Now this base class only has logic for measuring time.

R=het@google.com, johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b741e3f0df61662984e836c17bafe143c0b90c71
==========

[Siggi Cherem (dart-lang), 2016-05-25 16:11:15]

Committed patchset #1 (id:80001) manually as
b741e3f0df61662984e836c17bafe143c0b90c71 (presubmit successful).

[Siggi Cherem (dart-lang), 2016-05-25 16:11:18]

thanks

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/tasks.dart (right):

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:12: /// This exposes [measure] and
[measureIo], which wrap an action and assotiate
On 2016/05/25 15:51:36, Harry Terkelsen wrote:
> assotiate -> associate

Done.

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:13: /// the time spend during that action
with this task. Nested measurements can be
On 2016/05/25 15:51:36, Harry Terkelsen wrote:
> spend -> spent

Done.

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:32: // Note: it would be sufficient to
mark this getter abstract if we had enough
On 2016/05/25 15:51:36, Harry Terkelsen wrote:
> this note seems more like a TODO

Yeah, not sure if it's worth deleting. Rephrase the comment to encourage to
override this, but kept the current implementation for now.

https://codereview.chromium.org/2000323006/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/tasks.dart:56: /// Perform [action] and use [_watch]
to measure its runtime (including any
On 2016/05/25 15:51:36, Harry Terkelsen wrote:
> maybe remove the part about _watch in the docs since it's an implementation
> detail. Just "perform action and measure..."

good point, done.