Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2000303003: Update cached height for popup notifications after shelf alignment changes (Closed)

Created:
4 years, 7 months ago by yoshiki
Modified:
4 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update cached height for popup notifications after shelf alignment changes This patch fixes the misaligned notification issue. See the bug for detail. BUG=606808 TEST=manual tested Committed: https://crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4 Cr-Commit-Position: refs/heads/master@{#395795}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ash/system/tray/system_tray.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
yoshiki
skuhne@, PTAL. Thanks.
4 years, 7 months ago (2016-05-24 17:20:57 UTC) #4
Mr4D (OOO till 08-26)
You get an extra plus if you are able to add a unit test! :) ...
4 years, 7 months ago (2016-05-24 17:59:24 UTC) #5
yoshiki
On 2016/05/24 17:59:24, Mr4D wrote: > You get an extra plus if you are able ...
4 years, 7 months ago (2016-05-25 03:53:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000303003/20001
4 years, 7 months ago (2016-05-25 03:54:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-25 03:58:37 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 04:00:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4
Cr-Commit-Position: refs/heads/master@{#395795}

Powered by Google App Engine
This is Rietveld 408576698