Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/test/base/testing_browser_process.cc

Issue 20003005: Fix remaining leaks in StorageMonitorLinux. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/storage_monitor/test_storage_monitor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/testing_browser_process.cc
===================================================================
--- chrome/test/base/testing_browser_process.cc (revision 213177)
+++ chrome/test/base/testing_browser_process.cc (working copy)
@@ -329,13 +329,6 @@
NOTIMPLEMENTED();
return NULL;
#else
- if (!storage_monitor_.get()) {
- chrome::test::TestStorageMonitor* monitor =
vandebo (ex-Chrome) 2013/07/24 14:42:59 Why get rid of this, this is how a lot of things i
- new chrome::test::TestStorageMonitor();
- monitor->Init();
- monitor->MarkInitialized();
- storage_monitor_.reset(monitor);
- }
return storage_monitor_.get();
#endif
}
@@ -422,6 +415,6 @@
void TestingBrowserProcess::SetStorageMonitor(
scoped_ptr<chrome::StorageMonitor> storage_monitor) {
#if !defined(OS_IOS) && !defined(OS_ANDROID)
- storage_monitor_.reset(storage_monitor.release());
+ storage_monitor_ = storage_monitor.Pass();
#endif
}
« no previous file with comments | « chrome/browser/storage_monitor/test_storage_monitor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698