Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2000253005: Use nullptr instead of 0 in call to FontConfig. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use nullptr instead of 0 in call to FontConfig. Committed: https://skia.googlesource.com/skia/+/6d195b22bf6b7eed2b1867f2742e0b829c89e8e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000253005/1
4 years, 7 months ago (2016-05-24 14:24:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 14:43:19 UTC) #6
bungeman-skia
We inherited these 0's from Chromium. Replace them will nullptr since they're actually pointers.
4 years, 7 months ago (2016-05-24 15:05:48 UTC) #8
mtklein
lgtm
4 years, 7 months ago (2016-05-24 15:07:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000253005/1
4 years, 7 months ago (2016-05-24 15:07:21 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 15:08:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6d195b22bf6b7eed2b1867f2742e0b829c89e8e1

Powered by Google App Engine
This is Rietveld 408576698