Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2000253002: Add thunks for MojoDuplicateHandle[WithReducedRights](). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work792_dup_handle_1
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -55 lines) Patch
M mojo/edk/embedder/entrypoints.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 23 chunks +51 lines, -21 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 18 chunks +93 lines, -20 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/interface.py View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 6 chunks +59 lines, -6 lines 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/mojo_irt.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private.h View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.h View 2 chunks +10 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.c View 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_unittest.cc View 6 chunks +47 lines, -8 lines 0 comments Download
M mojo/public/platform/native/system_thunks.h View 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.c View 1 chunk +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/2001673003/.
4 years, 7 months ago (2016-05-23 17:58:08 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-23 18:20:32 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-23 19:14:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef5cd660ec6f1c50eaff62c81ea7662662d04e15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698