components/ntp_snippets.gypi - Issue 2000233002: [NTP Snippets] Unschedule fetches when the service should be disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets.gypi

Issue 2000233002: [NTP Snippets] Unschedule fetches when the service should be disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SnippetsDB

Patch Set: Please only look at ntp_snippets_service.*, the rest is because of the merge gone bad. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java ('K') | « components/components_tests.gyp ('k') | components/ntp_snippets/BUILD.gn » ('j') | components/ntp_snippets/ntp_snippets_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets.gypi

diff --git a/components/ntp_snippets.gypi b/components/ntp_snippets.gypi

index 215b2ce305b2c869fb9cc7f6752bcc5cddaa0585..6a0e06e71061772e658acf9480b166b9fecabe61 100644

--- a/components/ntp_snippets.gypi

+++ b/components/ntp_snippets.gypi

@@ -20,6 +20,7 @@

'data_use_measurement_core',

'image_fetcher',

'keyed_service_core',

+ 'leveldb_proto',

'prefs/prefs.gyp:prefs',

'signin_core_browser',

'suggestions',

@@ -31,6 +32,8 @@

'ntp_snippets/ntp_snippet.h',

'ntp_snippets/ntp_snippets_constants.cc',

'ntp_snippets/ntp_snippets_constants.h',

+ 'ntp_snippets/ntp_snippets_database.cc',

+ 'ntp_snippets/ntp_snippets_database.h',

'ntp_snippets/ntp_snippets_fetcher.cc',

'ntp_snippets/ntp_snippets_fetcher.h',

'ntp_snippets/ntp_snippets_scheduler.h',

@@ -38,9 +41,15 @@

'ntp_snippets/ntp_snippets_service.h',

'ntp_snippets/pref_names.cc',

'ntp_snippets/pref_names.h',

+ 'ntp_snippets/proto/ntp_snippets.proto',

'ntp_snippets/switches.cc',

'ntp_snippets/switches.h',

+ 'variables': {

+ 'proto_in_dir': 'ntp_snippets/proto',

+ 'proto_out_dir': 'components/ntp_snippets/proto',

+ },

+ 'includes': [ '../build/protoc.gypi' ],

}