Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/core/rendering/shapes/BoxShape.cpp

Issue 200023002: Making LayoutUnit conversions to Float type explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/shapes/BoxShape.cpp
diff --git a/Source/core/rendering/shapes/BoxShape.cpp b/Source/core/rendering/shapes/BoxShape.cpp
index 563814048bfcf1f563b1e4b1f3f7de09ce59a0da..4fb0b3dc25b4aa606df2809b8c866f8238f33b7d 100644
--- a/Source/core/rendering/shapes/BoxShape.cpp
+++ b/Source/core/rendering/shapes/BoxShape.cpp
@@ -76,8 +76,8 @@ void BoxShape::getExcludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalHei
if (marginBounds.isEmpty() || !lineOverlapsShapeMarginBounds(logicalTop, logicalHeight))
return;
- float y1 = logicalTop;
- float y2 = logicalTop + logicalHeight;
+ float y1 = logicalTop.toFloat();
+ float y2 = logicalTop.toFloat() + logicalHeight.toFloat();
leviw_travelin_and_unemployed 2014/03/14 18:25:26 Add first, then toFloat() the result. This uses in
gnana 2014/03/18 14:20:18 Done.
const FloatRect& rect = marginBounds.rect();
if (!marginBounds.isRounded()) {
@@ -118,8 +118,8 @@ void BoxShape::getIncludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalHei
if (paddingBounds.isEmpty())
return;
- float y1 = logicalTop;
- float y2 = logicalTop + logicalHeight;
+ float y1 = logicalTop.toFloat();
+ float y2 = logicalTop.toFloat() + logicalHeight.toFloat();
leviw_travelin_and_unemployed 2014/03/14 18:25:26 ditto
gnana 2014/03/18 14:20:18 Done.
const FloatRect& rect = paddingBounds.rect();
if (y1 < rect.y() || y2 > rect.maxY())

Powered by Google App Engine
This is Rietveld 408576698