Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000223002: Revert "Adjusts dart2js backend to handle method type arguments." (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Adjusts dart2js backend to handle method type arguments." This reverts commit 04e45eb634fe06c293cdb9fbd973ed2614431bed. BUG= Committed: https://github.com/dart-lang/sdk/commit/912bcc841862d079659620400561b052b106d3a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -368 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +3 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +3 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 4 chunks +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 11 chunks +9 lines, -99 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +0 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +10 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +15 lines, -41 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/generic_methods_function_type_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language/generic_methods_function_type_test.options View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/language/generic_methods_new_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/language/generic_methods_new_test.options View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/language/generic_methods_type_expression_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/language/generic_methods_type_expression_test.options View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
TBR, revert due to missing status file updates.
4 years, 7 months ago (2016-05-23 16:35:39 UTC) #2
eernst
Committed patchset #1 (id:1) manually as 912bcc841862d079659620400561b052b106d3a1 (presubmit successful).
4 years, 7 months ago (2016-05-23 16:36:07 UTC) #4
Johnni Winther
4 years, 7 months ago (2016-05-24 07:38:12 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698