Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2000153002: Handle constant function references. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add invariant from previous CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 2 chunks +8 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
4 years, 7 months ago (2016-05-23 12:52:42 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years, 7 months ago (2016-05-23 16:42:15 UTC) #4
Johnni Winther
4 years, 7 months ago (2016-05-24 07:52:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e0594d7b7e9748700bea4c56bf5e57e42b91dac2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698