Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000093005: Support extraction of lazily-loaded images (Closed)

Created:
4 years, 7 months ago by wychen
Modified:
4 years, 6 months ago
Reviewers:
mdjones
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support extraction of lazily-loaded images BUG=481111 R=mdjones@chromium.org Committed: f6d2dc1d024c13ce71b0c52290cdcb4a6594e8ed

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M java/org/chromium/distiller/extractors/embeds/ImageExtractor.java View 1 3 chunks +24 lines, -5 lines 0 comments Download
M java/org/chromium/distiller/webdocument/WebImage.java View 1 chunk +1 line, -0 lines 0 comments Download
M javatests/org/chromium/distiller/ContentExtractorTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M javatests/org/chromium/distiller/EmbedExtractorTest.java View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wychen
PTAL
4 years, 7 months ago (2016-05-24 00:53:11 UTC) #2
mdjones
lgtm % comment nit https://codereview.chromium.org/2000093005/diff/1/java/org/chromium/distiller/extractors/embeds/ImageExtractor.java File java/org/chromium/distiller/extractors/embeds/ImageExtractor.java (right): https://codereview.chromium.org/2000093005/diff/1/java/org/chromium/distiller/extractors/embeds/ImageExtractor.java#newcode46 java/org/chromium/distiller/extractors/embeds/ImageExtractor.java:46: // Try to get lazily-loaded ...
4 years, 6 months ago (2016-06-03 23:43:38 UTC) #3
wychen
https://codereview.chromium.org/2000093005/diff/1/java/org/chromium/distiller/extractors/embeds/ImageExtractor.java File java/org/chromium/distiller/extractors/embeds/ImageExtractor.java (right): https://codereview.chromium.org/2000093005/diff/1/java/org/chromium/distiller/extractors/embeds/ImageExtractor.java#newcode46 java/org/chromium/distiller/extractors/embeds/ImageExtractor.java:46: // Try to get lazily-loaded images. On 2016/06/03 23:43:38, ...
4 years, 6 months ago (2016-06-04 00:24:40 UTC) #4
wychen
4 years, 6 months ago (2016-06-04 00:25:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f6d2dc1d024c13ce71b0c52290cdcb4a6594e8ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698